chore(tests): delete a Python test that nothing runs #576

Merged

binjovi-bot merged 1 commit from sean/drop-dangling-python into trunk 2026-09-10 14:56:35 +00:00 AGit

Conversation 0 Commits 1 Files changed 1 -23

sean commented 2026-09-10 14:54:33 +00:00

Owner

Copy link

tests/test_node_taints.py had no caller of any kind: absent from tests/check.sh and the Makefile, and tests/every-guard-has-a-caller.sh structurally cannot see it because its glob is tests/.sh and tests//run-all.sh, so a .py file under tests/ is invisible to the guard whose job is finding guards without callers. Its subject, scripts/lib/node_taints.py, validates K3S_NODE_TAINTS before k3s-add-node.sh makes any Hetzner API call, and is therefore untested today because the only test of it never ran. Deleting it changes what is true by nothing and stops it implying coverage that does not exist. The full parallel tests/check.sh passes in 120 seconds. https://claude.ai/code/session_01KZoQin34jeyt6nDGqvJA76

tests/test_node_taints.py had no caller of any kind: absent from tests/check.sh and the Makefile, and tests/every-guard-has-a-caller.sh structurally cannot see it because its glob is tests/*.sh and tests/*/run-all.sh, so a .py file under tests/ is invisible to the guard whose job is finding guards without callers. Its subject, scripts/lib/node_taints.py, validates K3S_NODE_TAINTS before k3s-add-node.sh makes any Hetzner API call, and is therefore untested today because the only test of it never ran. Deleting it changes what is true by nothing and stops it implying coverage that does not exist. The full parallel tests/check.sh passes in 120 seconds. https://claude.ai/code/session_01KZoQin34jeyt6nDGqvJA76

sean added 1 commit 2026-09-10 14:54:33 +00:00

chore(tests): delete a Python test that nothing runs ... 07829aaf95

tests/test_node_taints.py had no caller of any kind. It is absent from
tests/check.sh and from the Makefile, and tests/every-guard-has-a-caller.sh
structurally cannot see it: its glob is `tests/*.sh` and `tests/*/run-all.sh`,
so a `.py` file under tests/ is invisible to the guard whose whole job is
finding guards without callers.

Its subject, scripts/lib/node_taints.py, is production Python -- it
regex-validates K3S_NODE_TAINTS and renders a node-taint fragment before
scripts/k3s-add-node.sh:45 makes any Hetzner API call. That subject is
therefore untested TODAY, because the only test of it never ran. Deleting the
file changes what is true by exactly nothing and stops it implying coverage
that does not exist.

Tests here use bash and jq; see AGENTS.md.

The full parallel tests/check.sh passes in 120 seconds.

Claude-Session: https://claude.ai/code/session_01KZoQin34jeyt6nDGqvJA76

binjovi-bot merged commit 07829aaf95 into trunk 2026-09-10 14:56:35 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

sean/seanfarm!576

No description provided.