fix(binjovi): grant the legacy read for hermes #590
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/hermes-legacy-read"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The
forgejorepositoriesgrant listed 40 names against 41ForgejoRepositoryBindings, andhermeswas the missing one.Measured, not guessed — the binding legacy names and the grant were compared directly:
Why it matters
The grant is
resourceNames-scoped, so a missing name does not read as "no legacy controller present" — it reads as denied. Adoption then fails looking like a permission fault rather than a live CR, which is precisely the distinctionlegacy_absentexists to make.This is the same defect that stopped every Codeberg mirror create until the
forgejopushmirrorsrule landed in #588. That one I caused; this one was already latent and would have surfaced the next time anyone tried to adopthermes.Guard
Now asserts 41, and names the four legacy aliases that differ from their repository name —
ibmi-examples,platform-seanfarm-gitops,seanfarm-gitops,zerotierone— plushermes. A typo in an alias now fails as loudly as a missing entry, which a bare count would not catch.The list cannot be derived from
repository-bootstrap.jsonhere: those are repository names, these are CR names, and the binding list lives insean/binjovi.Both controls confirmed red before this landed:
hermesremoved again -> fails on the countzerotierone-typo-> fails on the alias assertionPassing:
binjovi-repository-bootstrap,binjovi-service-handoff,binjovi-collaborator-bootstrap,binjovi.https://claude.ai/code/session_01TdW5FSvRJW8CtGnpd29Xp8