sean/binjovi-plans
Watch
1
0
Fork
You've already forked binjovi-plans
 0
Code Issues Pull requests 1 Projects Releases 156 Packages Wiki Activity

fix(seanfarm): the guard catalog must not name a guard that is being retired #205

Merged
binjovi-bot merged 1 commit from sean/drop-retired-guard-from-catalog into trunk 2026-09-10 12:22:52 +00:00 AGit
Conversation 0 Commits 1 Files changed 2 -2
sean commented 2026-09-10 12:22:33 +00:00
Owner
Copy link

The binjovi group selects on tests/binjovi*.sh and then runs its own fixed build_checks list of eleven guards, one of which is tests/binjovi-buildkit-cache-v2-retirement.sh. seanfarm is retiring that guard because the tombstone it watches is spent. Deleting the guard makes the selector name a file the revision does not have, and the validator refuses before running anything: 'binjovi-gitops-validate: selected check does not exist'. So the catalog entry has to go first, and only that order works. Removing it here while the guard still exists is harmless, because an unselected guard is still called by tests/check.sh. scripts/check pins the list exactly, so the pin moves with it; a control confirms that the two disagreeing is a failure. https://claude.ai/code/session_01KZoQin34jeyt6nDGqvJA76

The binjovi group selects on tests/binjovi*.sh and then runs its own fixed build_checks list of eleven guards, one of which is tests/binjovi-buildkit-cache-v2-retirement.sh. seanfarm is retiring that guard because the tombstone it watches is spent. Deleting the guard makes the selector name a file the revision does not have, and the validator refuses before running anything: 'binjovi-gitops-validate: selected check does not exist'. So the catalog entry has to go first, and only that order works. Removing it here while the guard still exists is harmless, because an unselected guard is still called by tests/check.sh. scripts/check pins the list exactly, so the pin moves with it; a control confirms that the two disagreeing is a failure. https://claude.ai/code/session_01KZoQin34jeyt6nDGqvJA76
fix(seanfarm): the guard catalog must not name a guard that is being retired
All checks were successful
binjovi/ci Binjovi completed the frozen plan
Details
f23bb728fb
 
THE CATALOG IS A FIXED LIST, NOT THE CHANGED FILE. The binjovi group selects
on `tests/binjovi*.sh`, so any change under that pattern selects the group,
and the group then runs its own fixed `build_checks` list of eleven guards.
One of them is `tests/binjovi-buildkit-cache-v2-retirement.sh`.

seanfarm is retiring that guard, because the tombstone it watches is spent:
its four targets are all NotFound, so the Job fails on `curl: (22)` every run.
Deleting the guard makes the selector name a file the revision does not have,
and the validator refuses before it runs anything:

  binjovi-gitops-validate: selected check does not exist:
  tests/binjovi-buildkit-cache-v2-retirement.sh

So the catalog entry has to go FIRST. Order matters and only one order works.
Removing it here while the guard still exists is harmless: an unselected guard
is still called by `tests/check.sh`, which the repository-guard-catalog group
selects. Removing the guard first is what fails, and it fails the whole
validation rather than one check.

scripts/check pins this list exactly, so the pin moves with it. A control
confirms the two disagreeing is a failure.

Claude-Session: https://claude.ai/code/session_01KZoQin34jeyt6nDGqvJA76
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
sean/binjovi-plans!205
No description provided.