sean/binjovi-plans
Watch
1
0
Fork
You've already forked binjovi-plans
 0
Code Issues Pull requests 1 Projects Releases 156 Packages Wiki Activity

chore(catalog): drop the spent Hermes retirement declaration #303

Merged
binjovi-bot merged 1 commit from chore/drop-hermes-retirement into trunk 2026-09-13 17:40:07 +00:00
Conversation 0 Commits 1 Files changed 1 -3
sean commented 2026-09-13 17:39:32 +00:00
Owner
Copy link

The bundle that retires hermes is active, so the declaration added in #301 has
done its work and now has to come out.

Binjovi.Control.PlanSource.validate_additive/2 compares the projects removed
since the active bundle against the declaration in the candidate. With
hermes already absent from the active bundle, removed is [] while
declared is still ["hermes"], which lands on the
project_retirement_mismatch branch of the same function.

Left in place, this key would refuse the next catalog change anyone makes --
silently, exactly the way it refused #297: release reports success, bundle.json
on trunk reads correctly, and the control plane just keeps serving the previous
catalog until something two repositories away fails for a reason that looks
unrelated.

Removing it returns both sides to [].

bash scripts/check passes.

https://claude.ai/code/session_01GfkEuwuvGSqGyXVuxwT7PA

The bundle that retires `hermes` is active, so the declaration added in #301 has done its work and now has to come out. `Binjovi.Control.PlanSource.validate_additive/2` compares the projects removed since the *active* bundle against the declaration in the *candidate*. With `hermes` already absent from the active bundle, `removed` is `[]` while `declared` is still `["hermes"]`, which lands on the `project_retirement_mismatch` branch of the same function. Left in place, this key would refuse the **next** catalog change anyone makes -- silently, exactly the way it refused #297: release reports success, `bundle.json` on trunk reads correctly, and the control plane just keeps serving the previous catalog until something two repositories away fails for a reason that looks unrelated. Removing it returns both sides to `[]`. `bash scripts/check` passes. https://claude.ai/code/session_01GfkEuwuvGSqGyXVuxwT7PA
chore(catalog): drop the spent Hermes retirement declaration
All checks were successful
binjovi/ci Binjovi completed the frozen plan
Details
cb52059eed
 
The bundle that retires hermes is active, so the declaration has done
its work and now has to come out.

PlanSource.validate_additive/2 compares the projects removed since the
active bundle against the declaration in the candidate. With hermes
already absent from the active bundle, removed is [] while declared is
still ["hermes"], which is the project_retirement_mismatch branch. Left
in place, this key would refuse the NEXT catalog change anyone makes,
silently, the way it refused this one.

Removing it returns both sides to [] and the comparison passes.

Claude-Session: https://claude.ai/code/session_01GfkEuwuvGSqGyXVuxwT7PA
binjovi-bot deleted branch chore/drop-hermes-retirement 2026-09-13 17:40:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
sean/binjovi-plans!303
No description provided.