sean/binjovi
Watch
1
0
Fork
You've already forked binjovi
 0
Code Issues Pull requests 1 Projects Releases 745 Packages Wiki Activity

fix: match repo-creator's release patch to its real container name #1724

Merged
binjovi-bot merged 1 commit from fix/repo-creator-container-name into trunk 2026-09-13 11:06:12 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
sean commented 2026-09-13 11:04:06 +00:00
Owner
Copy link

Summary

ReleaseManifests.agent_release_manifest/2 named the
binjovi-repo-creator companion's container agent, copied from the
sibling companion-agent template it was modeled on. The Deployment
itself (manifests/repo-creator.yaml, shipped in #1718) names its one
container control-plane, since it runs the same binjovi release as
the control plane, not the separate binjovi_agent release.

Confirmed live in production: the mismatch meant a strategic-merge
patch never matched the existing container, so it added a second
agent container with a real image instead of fixing control-plane,
which stayed pinned to the :bootstrap placeholder tag and was
rejected outright by the binjovi namespace's
binjovi-image-digest-pinned ValidatingAdmissionPolicy
(every container image ... must be referenced by immutable digest).
The Deployment never got a pod past FailedCreate / ProgressDeadlineExceeded.
This did not affect the main control plane or any required companion
(both stayed healthy; binjovi-repo-creator has no traffic depending
on it yet), but it needs fixing before the credential-isolation work
in #1718 is actually usable.

Test plan

  • make check (full local equivalent, including postgres) — green
  • Confirmed the container name now matches manifests/repo-creator.yaml
  • Live confirmation once released: binjovi-repo-creator gets a
    healthy pod and the agent sidecar container disappears on the
    next publish

https://claude.ai/code/session_01JGe4pyhQ36AhgDfPJry4d3

## Summary `ReleaseManifests.agent_release_manifest/2` named the `binjovi-repo-creator` companion's container `agent`, copied from the sibling companion-agent template it was modeled on. The Deployment itself (`manifests/repo-creator.yaml`, shipped in #1718) names its one container `control-plane`, since it runs the same `binjovi` release as the control plane, not the separate `binjovi_agent` release. Confirmed live in production: the mismatch meant a strategic-merge patch never matched the existing container, so it added a *second* `agent` container with a real image instead of fixing `control-plane`, which stayed pinned to the `:bootstrap` placeholder tag and was rejected outright by the `binjovi` namespace's `binjovi-image-digest-pinned` `ValidatingAdmissionPolicy` (`every container image ... must be referenced by immutable digest`). The Deployment never got a pod past `FailedCreate` / `ProgressDeadlineExceeded`. This did not affect the main control plane or any required companion (both stayed healthy; `binjovi-repo-creator` has no traffic depending on it yet), but it needs fixing before the credential-isolation work in #1718 is actually usable. ## Test plan - [x] `make check` (full local equivalent, including postgres) — green - [x] Confirmed the container name now matches `manifests/repo-creator.yaml` - [ ] Live confirmation once released: `binjovi-repo-creator` gets a healthy pod and the `agent` sidecar container disappears on the next publish https://claude.ai/code/session_01JGe4pyhQ36AhgDfPJry4d3
fix(control): match repo-creator's release patch to its real container name
All checks were successful
binjovi/ci Binjovi completed the frozen plan
Details
73974104f6
 
ReleaseManifests.agent_release_manifest/2 named the binjovi-repo-creator
container "agent", copied from the sibling companion-agent template.
The Deployment itself (manifests/repo-creator.yaml) names its one
container "control-plane", since it runs the same binjovi release as
the control plane, not the separate binjovi_agent release.

The mismatch meant a strategic-merge patch never matched an existing
container: it added a second "agent" container with a real image
instead of fixing "control-plane", which stayed pinned to the
:bootstrap placeholder and was rejected outright by this namespace's
binjovi-image-digest-pinned ValidatingAdmissionPolicy. Confirmed live:
the Deployment never got a pod past FailedCreate until this is fixed.

Claude-Session: https://claude.ai/code/session_01JGe4pyhQ36AhgDfPJry4d3
binjovi-bot deleted branch fix/repo-creator-container-name 2026-09-13 11:06:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
sean/binjovi!1724
No description provided.