merge fix/backoff-float-overflow (4544a909f9) #4

Open

pipeline-bot wants to merge 1 commit from fix/backoff-float-overflow into trunk

pull from: fix/backoff-float-overflow

merge into: sean:trunk

sean:main

sean:trunk

Conversation 0 Commits 1 Files changed 2 +18 -6

pipeline-bot commented 2026-07-16 06:04:44 +00:00

Collaborator

Copy link

No description provided.

pipeline-bot added 1 commit 2026-07-16 06:04:44 +00:00

fix(backoff): cap exponential backoff in the float domain (amd64 float->int64 overflow) ... 4544a909f9

time.Duration(float64(InitialBackoff) * 2^failureCount) overflows int64
for failureCount ~>= 33. Float->int64 overflow is architecture-dependent:
arm64 saturates to MaxInt64 (the post-conversion cap then works — why
the suite always passed on the dev Macs), amd64 wraps to MinInt64, the
'delay > MaxBackoff' cap misses the negative, and the jitter subtraction
underflows int64 BACK to a positive ~263-year backoff (8.3e18ns observed).
Cap in float space (incl. +Inf/NaN) before converting. Found by the
pipeline-test-envtest gate's amd64 pod blocking release v0.3.5 — the
'should cap at maxBackoff' spec is a faithful regression test on amd64.

All checks were successful

Hide checks

pipeline/ci CI green v0.3.5

Required

Details

This pull request has changes conflicting with the target branch.

• CHANGELOG.md

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title Merge pull request 'merge fix/backoff-float-overflow (4544a909f96f)' (#4) from fix/backoff-float-overflow into trunk

Merge commit body Reviewed-on: https://code.sean.farm/sean/minio-resource-operator/pulls/4

Merge pull request 'merge fix/backoff-float-overflow (4544a909f96f)' (#4) from fix/backoff-float-overflow into trunk Reviewed-on: https://code.sean.farm/sean/minio-resource-operator/pulls/4 Copy merge commit message

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin fix/backoff-float-overflow:fix/backoff-float-overflow

git switch fix/backoff-float-overflow

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

sean/minio-resource-operator!4

No description provided.