Bound the composer per unit and harden template and by-reference paths #597

Manually merged
binjovi-bot merged 1 commit from rpg-9-a-template-oom-20261021 into trunk 2026-10-22 11:09:48 +00:00
Owner

Round 9 track A: composer bounds and hardening of the template and by-reference paths.

  • Composer: a unit with "alone": true never shares a program. placeholderdisplay is alone: shared, it gave 5 blocking DDS TODOs; alone, 1 dds_todo_placeholder_other_v1 per program with 0 failures. placeholderspec is disabled (the unit that yields the form adds a failed statement); the plan refuses placeholder_specification_count_v1 with a reason and keeps it in the requested total.
  • compose-check.sh counts refused forms in the total and exits 1 while any form is refused.
  • Hardening: owned array-argument slice with errdefer; overflow guards in rpg_source_byref.copyCheck, rpg_source_parts.partInfo and rpg_source.zig, each with a test. QTEMP compile batch prints host message IDs on failure.
  • No emitter behavior change on public twins.

Gates on base 4c23ed1d (baseline from the same commit):

gate result
full Build v22 check exit 0
twins 391 groups, 379 recovered, 0 missing, 0 regressions
all-groups 9142; 0 missing, 0 regressions, 0 worse
emission worse [], failures 701 -> 701, clean 192 -> 192
focused tests/cli/compose-probe.sh ok

Private evidence (counts only): the 17-program alone capture compiled 17/17; compose-check 103 of 105 requested forms at count, 1 refused (dds_comment_v1), placeholder_specification_count_v1 want 2 got 0 (disabled unit).

Not run here: the changed-text round trip of the composed programs (loop/roundtrip.sh), which gates release.

Round 9 track A: composer bounds and hardening of the template and by-reference paths. - Composer: a unit with `"alone": true` never shares a program. `placeholderdisplay` is alone: shared, it gave 5 blocking DDS TODOs; alone, 1 `dds_todo_placeholder_other_v1` per program with 0 failures. `placeholderspec` is disabled (the unit that yields the form adds a failed statement); the plan refuses `placeholder_specification_count_v1` with a reason and keeps it in the requested total. - `compose-check.sh` counts refused forms in the total and exits 1 while any form is refused. - Hardening: owned array-argument slice with `errdefer`; overflow guards in `rpg_source_byref.copyCheck`, `rpg_source_parts.partInfo` and `rpg_source.zig`, each with a test. QTEMP compile batch prints host message IDs on failure. - No emitter behavior change on public twins. Gates on base `4c23ed1d` (baseline from the same commit): | gate | result | |---|---| | full Build v22 check | exit 0 | | twins | 391 groups, 379 recovered, 0 missing, 0 regressions | | all-groups | 9142; 0 missing, 0 regressions, 0 worse | | emission | worse [], failures 701 -> 701, clean 192 -> 192 | | focused `tests/cli/compose-probe.sh` | ok | Private evidence (counts only): the 17-program alone capture compiled 17/17; `compose-check` 103 of 105 requested forms at count, 1 refused (`dds_comment_v1`), `placeholder_specification_count_v1` want 2 got 0 (disabled unit). Not run here: the changed-text round trip of the composed programs (`loop/roundtrip.sh`), which gates release.
Bound the composer per unit and harden the template and by-reference paths
All checks were successful
binjovi/ci Binjovi completed the frozen plan
de6832dc5a
Add an alone bound to the composer catalog: placeholderdisplay never shares
a program, because a shared program measured five blocking DDS TODOs instead
of the placeholder form. Disable placeholderspec: the unit that yields the
form adds a failed statement. The plan refuses the form with a reason and
keeps it in the requested total; compose-check counts refused forms and
exits 1.

Own the array-argument slice with errdefer and guard the arithmetic that
could overflow in the by-reference copy check, the part info and the
statement walk. Print host message IDs when a QTEMP batch fails.

Gates on 4c23ed1d: full Build v22 check exit 0; twins 391 groups, 0
regressions; all-groups 0 missing, 0 regressions, 0 worse; emission
unchanged.
binjovi-bot manually merged commit 09288f2bbc into trunk 2026-10-22 11:09:48 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
sean/sourcerer!597
No description provided.