The rebuilt DDS takes its fields from the file definitions #692

Manually merged
binjovi-bot merged 1 commit from rpg-dds-from-definitions-20261101 into trunk 2026-11-01 10:03:22 +00:00
Owner

The rebuilt DDS takes its fields from the file definitions

With --files DEFS the emitter wrote no DDS members: the owner was assumed
to have the files. The round trip of a twin has only the rebuilt members to
compile against, so match_except_file_identity stayed: the members rebuilt
from the program alone carry the names of the recovered source, and their
level identifiers differ from the original's.

Now the program's files are rebuilt with definitions too, and a physical
file's record format takes the fields of its definition (DSPFFD): the
original names, types, lengths and decimal positions in buffer order. The
member says so in its header, and no filler or decimal-positions note
remains for it. The key lines name the key fields after the definitions.
Display, printer and logical files keep the program's rebuild. r5i-outspec
with its files.json writes R5IOUT.pf with OCODE 3A and OAMT 9P 2.

Gates

{"checks":{"net_statements":0},"census":{"statuses":{"recovered":645,"partial":0,"unresolved":0},"regressions":0,"newly_recovered":0},"golden":"golden 173/5/0 == dump 173/5/0","emit":{"worse":[],"better":103,"newly_clean":100,"clean_delta":100,"base":215,"new":315},"twins":{"groups":462,"recovered":454,"regressions":[],"newly":39},"allgroups":{"regressions":[],"newly":["rpg-corpus-captures/files-chain/stripped/object.savf 2","rpg-corpus-captures/files-display-write/stripped/object.savf 2","rpg-corpus-captures/files-logical/stripped/object.savf 2","savf/SC-CONSTRUCT/POINTER/rpg-pointer-procedure-auto/stripped/archive.savf 1","savf/SC-ILE/DSPLY/error-observable/archive.savf 2","savf/SC-ILE/DSPLY/error-stripped/archive.savf 2","savf/SC-ILE/DSPLY/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/d4-edit/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/d4-editc-codes/stripped/object.savf 16","savf/SC-ILE/EXPERIMENTS/d4-out-const/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/d4-out-input/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/d4-srcstmt-dspf/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/d7-args/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/d7c-copy/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/decimal-fault-report/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/decimal-sign-report/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/fmtind-j1/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/fmtind-j2/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/fmtind-j3/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/format-base/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/format-rename/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/gotos-auto/stripped/archive.savf 3","savf/SC-ILE/EXPERIMENTS/gotos-heldout/stripped/archive.savf 4","savf/SC-ILE/EXPERIMENTS/gotos-static/stripped/archive.savf 5","savf/SC-ILE/EXPERIMENTS/h-editc/stripped/object.savf 17","savf/SC-ILE/EXPERIMENTS/h-editc3/stripped/object.savf 24","savf/SC-ILE/EXPERIMENTS/h-editc5/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/h-editc6/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/h-fmix/stripped/object.savf 11","savf/SC-ILE/EXPERIMENTS/h-subind/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/loop-condition-owner-sql/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/loop-condition-owner-static/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/packed-add-report/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/packed-compose-report/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/packed-compose-sign-report/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/program-literal/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/r5b-onexit-for/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/r5c-cycle-files/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/r5e-date-field/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/r5e-editc-held/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/r5i-figurative/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/r5x-cycle-print/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/r6a-float-inz/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/r6a-reset-ds/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6a-reset-fixed/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6a-reset-two/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-blank/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-char/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-const/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-disk/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit1/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit2-int/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit2/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit3/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit4/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edita/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-editj/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-editword/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-editz/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-end/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ho-disk-two/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/r6e-ho-edit4-amt/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ho-editz-cnt/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ho-ind-const/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ho-nooflind-two/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/r6e-ho-oflind60-two/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/r6e-ind-fld/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ind-rec/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-nooflind/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-num/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-oflind50/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-skip/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-space/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-three-rec/stripped/object.savf 4","savf/SC-ILE/EXPERIMENTS/r6e-two-fld/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-two-rec/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/shared-io-full/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/shared-io-none/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/t8-retval/stripped/object.savf 1","savf/SC-ILE/FLOW/goto-subroutine-observable/archive.savf 3","savf/SC-ILE/FLOW/goto-subroutine-stripped/archive.savf 3","savf/SC-ILE/FLOW/return-fixed-observable/archive.savf 1","savf/SC-ILE/FLOW/return-fixed-stripped/archive.savf 1","savf/SC-ILE/MONITOR/limits-observable/archive.savf 1","savf/SC-ILE/MONITOR/limits-stripped/archive.savf 1","savf/SC-ILE/MONITOR/stripped/archive.savf 2","savf/SC-ILE/OPS/cond-not-observable/archive.savf 12","savf/SC-ILE/OPS/cond-not-stripped/archive.savf 12","savf/SC-ILE/OPS/fk-subp2-observable/archive.savf 1","savf/SC-ILE/OPS/fk-subp2-stripped/archive.savf 1","savf/SC-ILE/TSTRIP-STRIPPED/archive.savf 2","savf/SC-ILE/TSTRIP/archive.savf 2"],"worse":[]},"full_check":{"exit":0,"seconds":803}}
# The rebuilt DDS takes its fields from the file definitions With `--files DEFS` the emitter wrote no DDS members: the owner was assumed to have the files. The round trip of a twin has only the rebuilt members to compile against, so `match_except_file_identity` stayed: the members rebuilt from the program alone carry the names of the recovered source, and their level identifiers differ from the original's. Now the program's files are rebuilt with definitions too, and a physical file's record format takes the fields of its definition (DSPFFD): the original names, types, lengths and decimal positions in buffer order. The member says so in its header, and no filler or decimal-positions note remains for it. The key lines name the key fields after the definitions. Display, printer and logical files keep the program's rebuild. r5i-outspec with its `files.json` writes `R5IOUT.pf` with `OCODE 3A` and `OAMT 9P 2`. ## Gates ``` {"checks":{"net_statements":0},"census":{"statuses":{"recovered":645,"partial":0,"unresolved":0},"regressions":0,"newly_recovered":0},"golden":"golden 173/5/0 == dump 173/5/0","emit":{"worse":[],"better":103,"newly_clean":100,"clean_delta":100,"base":215,"new":315},"twins":{"groups":462,"recovered":454,"regressions":[],"newly":39},"allgroups":{"regressions":[],"newly":["rpg-corpus-captures/files-chain/stripped/object.savf 2","rpg-corpus-captures/files-display-write/stripped/object.savf 2","rpg-corpus-captures/files-logical/stripped/object.savf 2","savf/SC-CONSTRUCT/POINTER/rpg-pointer-procedure-auto/stripped/archive.savf 1","savf/SC-ILE/DSPLY/error-observable/archive.savf 2","savf/SC-ILE/DSPLY/error-stripped/archive.savf 2","savf/SC-ILE/DSPLY/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/d4-edit/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/d4-editc-codes/stripped/object.savf 16","savf/SC-ILE/EXPERIMENTS/d4-out-const/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/d4-out-input/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/d4-srcstmt-dspf/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/d7-args/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/d7c-copy/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/decimal-fault-report/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/decimal-sign-report/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/fmtind-j1/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/fmtind-j2/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/fmtind-j3/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/format-base/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/format-rename/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/gotos-auto/stripped/archive.savf 3","savf/SC-ILE/EXPERIMENTS/gotos-heldout/stripped/archive.savf 4","savf/SC-ILE/EXPERIMENTS/gotos-static/stripped/archive.savf 5","savf/SC-ILE/EXPERIMENTS/h-editc/stripped/object.savf 17","savf/SC-ILE/EXPERIMENTS/h-editc3/stripped/object.savf 24","savf/SC-ILE/EXPERIMENTS/h-editc5/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/h-editc6/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/h-fmix/stripped/object.savf 11","savf/SC-ILE/EXPERIMENTS/h-subind/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/loop-condition-owner-sql/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/loop-condition-owner-static/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/packed-add-report/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/packed-compose-report/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/packed-compose-sign-report/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/program-literal/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/r5b-onexit-for/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/r5c-cycle-files/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/r5e-date-field/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/r5e-editc-held/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/r5i-figurative/stripped/archive.savf 1","savf/SC-ILE/EXPERIMENTS/r5x-cycle-print/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/r6a-float-inz/stripped/object.savf 1","savf/SC-ILE/EXPERIMENTS/r6a-reset-ds/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6a-reset-fixed/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6a-reset-two/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-blank/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-char/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-const/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-disk/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit1/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit2-int/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit2/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit3/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edit4/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-edita/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-editj/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-editword/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-editz/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-end/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ho-disk-two/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/r6e-ho-edit4-amt/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ho-editz-cnt/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ho-ind-const/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ho-nooflind-two/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/r6e-ho-oflind60-two/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/r6e-ind-fld/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-ind-rec/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-nooflind/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-num/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-oflind50/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-skip/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-space/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-three-rec/stripped/object.savf 4","savf/SC-ILE/EXPERIMENTS/r6e-two-fld/stripped/object.savf 2","savf/SC-ILE/EXPERIMENTS/r6e-two-rec/stripped/object.savf 3","savf/SC-ILE/EXPERIMENTS/shared-io-full/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/shared-io-none/stripped/archive.savf 2","savf/SC-ILE/EXPERIMENTS/t8-retval/stripped/object.savf 1","savf/SC-ILE/FLOW/goto-subroutine-observable/archive.savf 3","savf/SC-ILE/FLOW/goto-subroutine-stripped/archive.savf 3","savf/SC-ILE/FLOW/return-fixed-observable/archive.savf 1","savf/SC-ILE/FLOW/return-fixed-stripped/archive.savf 1","savf/SC-ILE/MONITOR/limits-observable/archive.savf 1","savf/SC-ILE/MONITOR/limits-stripped/archive.savf 1","savf/SC-ILE/MONITOR/stripped/archive.savf 2","savf/SC-ILE/OPS/cond-not-observable/archive.savf 12","savf/SC-ILE/OPS/cond-not-stripped/archive.savf 12","savf/SC-ILE/OPS/fk-subp2-observable/archive.savf 1","savf/SC-ILE/OPS/fk-subp2-stripped/archive.savf 1","savf/SC-ILE/TSTRIP-STRIPPED/archive.savf 2","savf/SC-ILE/TSTRIP/archive.savf 2"],"worse":[]},"full_check":{"exit":0,"seconds":803}} ```
The rebuilt DDS takes its fields from the file definitions
All checks were successful
binjovi/ci Binjovi completed the frozen plan
7e75e6403f
With --files the emitter wrote no DDS members, so a round trip had only
the program's own rebuild to compile against and its level identifiers
differed. A physical file's record format now takes the fields of its
definition (names, types, lengths, decimal positions in buffer order), the
key lines name the fields after the definitions, and the member says so.
r5i-outspec, r7f-in-out and key-wide rebuild their original DDS.
binjovi-bot manually merged commit 7e75e6403f into trunk 2026-11-01 10:03:22 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
sean/sourcerer!692
No description provided.