fix(catalog): declare the Hermes project retirement #301
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/retire-hermes-project"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR #297 removed the
hermesproject from the catalog and merged cleanly, butthe control plane has been refusing the new bundle on every poll ever since
and quietly continuing to serve the old one.
Binjovi.Control.PlanSource.validate_additive/2:A catalog that drops a project has to declare it. Nothing surfaced the refusal
anywhere I was looking --
binjovictl status binjovi-plansreported the releaseas succeeded, and the raw
bundle.jsonon trunk was correct. It showed upindirectly, as seanfarm builds still selecting the retired
hermes-prerequisitesgroup and failing on a render path the seanfarm changedeletes:
Three seanfarm builds failed that way before I found this.
This key has to come back out
The declaration is transitional. Once this bundle is active, the next bundle
has
removed == []whiledeclaredis still["hermes"], which is theproject_retirement_mismatchbranch of the same function -- so the bundle afterthis one would be refused the same silent way. A follow-up PR drops the key
immediately after this activates.
Worth noting for its own sake: a validation failure that leaves the previous
catalog serving, with no failed status on the release that caused it, is hard to
find. The symptom appeared two repositories away.
bash scripts/checkpasses.https://claude.ai/code/session_01GfkEuwuvGSqGyXVuxwT7PA
PR 297 removed the hermes project from the catalog and merged, but the control plane has been refusing the new bundle on every poll ever since and quietly serving the old one. PlanSource.validate_additive/2: removed == declared -> :ok declared == [] -> {:error, {:project_removal_not_supported, removed}} A catalog that drops a project has to say so. Nothing surfaced the refusal; it showed up as seanfarm builds still selecting the hermes-prerequisites group and failing on a render path the seanfarm change deletes: binjovi-gitops-validate: selected render path does not exist: kubernetes/flux/infrastructure/hermes This declaration is transitional and must come out once this bundle is active. On the bundle after that, removed is [] while declared is still ["hermes"], which is the project_retirement_mismatch branch of the same function. A follow-up drops the key. Claude-Session: https://claude.ai/code/session_01GfkEuwuvGSqGyXVuxwT7PA